[feat] Allow "LicenseDir" field for non-enterprise usage - Githubissues

hashicorp / hc-install

Go module for downloading or locating HashiCorp binaries, verifying signatures and checksums, and asserting version constraints.

https://pkg.go.dev/github.com/hashicorp/hc-install

Mozilla Public License 2.0

50 stars 19 forks source link

[feat] Allow "LicenseDir" field for non-enterprise usage #214

Closed james0209 closed 3 months ago

james0209 commented 3 months ago

What

High-level overview

Introduces LicenseDir field into the following:

build.GitRevision
checkpoint.LatestVersion
releases.ExactVersion
releases.LatestVersion
versions.InstallationOptions

Removes LicenseDir field from:

EnterpriseOptions

build.GitRevision

When copying the license file (with or without .txt) from the repo, keep the name as-is.
- Currently, the license file created is always "LICENSE.txt".
Add destination path for the copied license file to pathsToRemove to match other uses.

checkpoint.LatestVersion

Pass LicenseDir to DownloadAndUnpack call
Currently an empty string is passed as checkpoint doesn't support Enterprise, and before this PR, it was assumed that only Enterprise versions would contain a License.

versions.InstallationOptions

Add LicenseDir to InstallationOptions - same struct that contains InstallDir.

Why

Closes #213