hashicorp / hcdiag

hcdiag is a CLI utility that collects and bundles product and platform diagnostics. It supports Consul, Nomad, TFE, and Vault.
Mozilla Public License 2.0
56 stars 8 forks source link

GitHub Actions - deprecated warnings found - golangci-lint #320

Closed sarahethompson closed 1 year ago

sarahethompson commented 1 year ago

Workflow Name: golangci-lint Branch: main Run URL: https://github.com/hashicorp/hcdiag/actions/runs/4056782167

save-state deprecation warnings: 0 set-output deprecation warnings: 0 node12 deprecation warnings: 1

Please review these deprecation warnings as soon as possible and merge in the necessary updates.

GitHub will be removing support for these commands and plan to fully disable them on 31st May 2023. At this time, any workflow that still utilizes these commands will fail. See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/.

GitHub have not finalized a date for deprecating node12 yet but have indicated that this will be summer 2023. So it is advised to switch to node16 asap. See https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

If you need any help, please reach out to us in #team-rel-eng.

nwchandler commented 1 year ago

Resolved by https://github.com/hashicorp/hcdiag/pull/318

Example "clean" run following PR merge: https://github.com/hashicorp/hcdiag/actions/runs/4993861425