search

hashicorp / hcl2

Former temporary home for experimental new version of HCL
https://github.com/hashicorp/hcl
Mozilla Public License 2.0
373 stars 66 forks source link

return array value evaluation diagnostics #113

Closed notnoop closed 5 years ago

notnoop commented 5 years ago

Fix a bug where diagnostics found when evaluating array individual elements are ignored, resulting in suppressed errors.

Nomad observed this issue in https://github.com/hashicorp/nomad/issues/5694.

codecov-io commented 5 years ago

Codecov Report

Merging #113 into master will increase coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   68.69%   68.75%   +0.05%     
==========================================
  Files          98       98              
  Lines       10299    10301       +2     
==========================================
+ Hits         7075     7082       +7     
+ Misses       2897     2894       -3     
+ Partials      327      325       -2
Impacted Files Coverage Δ
hcl/json/structure.go 68.44% <100%> (+1.44%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 318e80e...8a68b3e. Read the comment docs.