hashicorp / hil

HIL is a small embedded language for string interpolations.
Mozilla Public License 2.0
393 stars 33 forks source link

Go 1.10: eval_test.go:2048: Fatalf format %#s has unrecognized flag # #57

Closed nim-nim closed 5 years ago

nim-nim commented 6 years ago

fa9f258a92500514cc8e9c67020487709df92432 does not pass unit tests with Go 1.10. At least:

+ GOPATH=/builddir/build/BUILD/hil-fa9f258a92500514cc8e9c67020487709df92432/_build:/usr/share/gocode
+ go test -buildmode pie -compiler gc -ldflags '-extldflags '\''-Wl,-z,relro  '\'''
# github.com/hashicorp/hil
./eval_test.go:2048: Fatalf format %#s has unrecognized flag #
./eval_test.go:2051: Fatalf format %#s has unrecognized flag #
FAIL    github.com/hashicorp/hil [build failed]
radeksimko commented 5 years ago

Hi @nim-nim This was addressed in https://github.com/hashicorp/hil/pull/63

Thanks for the note and patience.

nim-nim commented 5 years ago

Thanks for the fixing!