Calling plist_options is deprecated

[corbishley]

got the following message when calling brew doctor

Warning: Calling plist_options is deprecated! Use service.require_root instead.
Please report this issue to the hashicorp/tap tap (not Homebrew/brew or Homebrew/core), or even better, submit a PR to fix it:
  /opt/homebrew/Library/Taps/hashicorp/homebrew-tap/Formula/vault.rb:37

[radeksimko]

This appears to be related to https://github.com/Homebrew/brew/pull/14113 and https://github.com/Homebrew/homebrew-core/pull/114915 AFAICT the plist_options manual: "..." stanzas can be removed entirely, although I'm not sure what the exact UX implications are - just looking at the second PR diff.

There is however other change which we may need to make in this tap, related more broadly to raw plist support deprecation in favour of the "native" service stanza which generates plist:

• https://github.com/Homebrew/homebrew-core/pull/71831
• https://github.com/Homebrew/brew/pull/9517

This would likely require deprecating/replacing the plist-related options in https://github.com/hashicorp/homebrew-tap/blob/b8b8da041c56919005ce6e3bb871007303ac1a69/util/formula_templater/config.go#L25-L26 and anywhere that depends on it.

[sramekmichal]

Same problem here

[dronenb]

Note there's an open PR addressing this issue.

[msiege2]

Note there's an open PR addressing this issue.

That PR only fixes vault. Would also need for other products (consul, nomad) as well as enterprise versions.

[jlucktay]

I've just put in a PR to update the code that generates the formulas, as well as updating the formulas themselves. Hope this helps!

[juliosaraiva]

I've just put in a PR to update the code that generates the formulas, as well as updating the formulas themselves. Hope this helps!

Merge it urgent please!