search

hashicorp / homebrew-tap

Homebrew Tap of HashiCorp products and tools
Mozilla Public License 2.0
134 stars 58 forks source link

Update formula_templater to swap 'plist' for 'service' #204

Closed jlucktay closed 1 year ago

jlucktay commented 1 year ago

The use of plist_options is deprecated by Homebrew, and causes brew to throw warnings such as the following:

image

c9f4f14da11626fe4e9966cab22dddaa11bc072a & 9a2cfead87a0f7464a00aa7033edd4d882e33ecd: Updated the expected test output and the generated output from the template in formula_templater to the service block instead of plist.

60d1ebda132da66c5a6d900d8ec9ead612eea14d: Ran gofumpt and fixed some basic lint issues in the formula_templater code.

6cce3f3927c3a87a9c3bbee03719b0a59746094a: Updated Go version and bumped dependencies for formula_templater.

18d7956e1d3772bfb2749cfa979063a55f28e8ea: Aligned checksums with SHA256SUMS files on https://releases.hashicorp.com.

e3241a2f228a43c143eb748c265233eddb20a69c: Ran formula_templater <service> <version> config.hcl on all formulas using plist.

Fixes #201.

hashicorp-cla commented 1 year ago

CLA assistant check
All committers have signed the CLA.

jlucktay commented 1 year ago

Ping some HashiCorp folks with recent activity here: @CalebAlbers @mdeggies @claire-labry - any chance of a review/merge please? 🙏

bennetfabian commented 1 year ago

@jlucktay Is this ready to be merged? @radeksimko Could you take a look at this?

The warning message is not the end of the world but of course it's a bit annoying

jlucktay commented 1 year ago

@jlucktay Is this ready to be merged?

Hi @bennetfabian - yes, this is ready to merge. 🚀

mdeggies commented 1 year ago

Hey @jlucktay, thanks for your contribution! The team is reviewing this and will get back to you with feedback shortly.