vagrant: fix for errors on macOS

[EricFromCanada]

Gating the URL behind an if statement causes errors on any macOS Homebrew installation that uses this tap. Instead, use depends_on to ensure only Linux on Intel can install it.

For example:

$ brew readall hashicorp/tap
Error: Invalid formula (sonoma): /usr/local/Homebrew/Library/Taps/hashicorp/homebrew-tap/Formula/vagrant.rb
formulae require at least a URL
Error: Invalid formula (arm64_sonoma): /usr/local/Homebrew/Library/Taps/hashicorp/homebrew-tap/Formula/vagrant.rb
formulae require at least a URL
Error: Invalid formula (ventura): /usr/local/Homebrew/Library/Taps/hashicorp/homebrew-tap/Formula/vagrant.rb
formulae require at least a URL
Error: Invalid formula (arm64_ventura): /usr/local/Homebrew/Library/Taps/hashicorp/homebrew-tap/Formula/vagrant.rb
formulae require at least a URL
…

[hashicorp-cla]

All committers have signed the CLA.

[baodrate]

Could we get some eyes on this? (@modrake? @sarahethompson?) This issue is quite painful for certain homebrew setups/flows (e.g. w/ https://github.com/rcmdnk/homebrew-file)

[EricFromCanada]

Rebased on current master. (@modrake @sarahethompson @dekimsey)

[dekimsey]

👋, this is interesting thank you for bringing it our attention! I'm going to loop someone in here as this correction actually needs to be performed in our template code so it sticks upon the next release and then the existing formulas regenerated.

Let me get some eyes on this, thank you again!

[EricFromCanada]

In that case, the template should be adjusted to use on_system blocks instead of if statements, and if only one OS and arch is supported, place the URL at the top level and use depends_on to limit where it can be installed. Good luck!

[baodrate]

I believe this issue is still relevant?

[EricFromCanada]

The original problem still exists, but the proper fix is to adjust the template that generates the formula file in question, which is better handled by this repository's maintainers.