hashicorp / learn-consul-kubernetes

Mozilla Public License 2.0
32 stars 37 forks source link

api-gateway: update for v0.4.0 release #72

Closed mikemorris closed 2 years ago

mikemorris commented 2 years ago

Updates

Will require corresponding updates over in https://github.com/hashicorp/tutorials/blob/main/content/tutorials/consul/kubernetes-api-gateway.mdx

nathancoleman commented 2 years ago

@mikemorris do you think it makes sense to update the version in cloud and local for things like consul-k8s, APIGW, etc. as part of this PR, or should I make a separate one?

mikemorris commented 2 years ago

@nathancoleman Oh should totally push a commit to this PR for cloud dir, I just hadn't walked through those myself.

nathancoleman commented 2 years ago

@mikemorris done!

mikemorris commented 2 years ago

Huh, seems a little strange that the api-gw and two-services directories are duplicated in cloud/ (didn't diff to see how close it is) but cloud deploys resources to different namesapces such that a a ReferenceGrant isn't required.

With the current state though, LGTM, thanks @nathancoleman!

nathancoleman commented 2 years ago

@mikemorris are we ready to merge this guy?