clients_ingress_sg role

[vitbyst]

what is resource "aws_security_group" "clients_ingress_sg" for?

[shankarnarayanb]

I agree, clients_ingress_sg security group is not being directly referenced in the aws_instance resource blocks in the main.tf and could be potentially removed. Maybe @tunzor orginally intended this to be used to allow incoming traffic from the Internet to the client instances within an aws_autoscaling_group, but I am not really sure? @tunzor, would you be happy for me to raise a PR to make the change to remove clients_ingress_sg?

[tunzor]

Thanks for the comments! @shankarnarayanb is correct, it was intended for ingress to applications running on the client nodes.

We've got some updates coming soon that include the renaming of resources for clarity so you don't need to open a PR but it's very much appreciated!