search

hashicorp / memberlist

Golang package for gossip based membership and failure detection
Mozilla Public License 2.0
3.62k stars 435 forks source link

tests: Use net.JoinHostPort() #224

Closed russellb closed 4 years ago

russellb commented 4 years ago

While starting to look at how memberlist is used by a project, I was browsing around and happened to notice these lines that manually joined the bind address and port. While it's not actually causing a problem with these tests, it's good practice to always use net.JoinHostPort() to do this, which will ensure that IPv6 addresses are handled correctly.

hashicorp-cla commented 4 years ago

CLA assistant check
All committers have signed the CLA.