search

hashicorp / memberlist

Golang package for gossip based membership and failure detection
Mozilla Public License 2.0
3.66k stars 443 forks source link

Explicit transport protocols in state errors: TCP or UDP #258

Closed krastin closed 2 years ago

krastin commented 2 years ago

As described in issue #234 , when troubleshooting connectivity issues, end-users routinely get confused that Memberlist ping messages are ICMP packets.

I'm basing my edits on the fact that Memberlist pings were already referred to as UDP Ping here:

https://github.com/hashicorp/memberlist/blob/a43ca4a5f16cd26cbf7b27eb613982bfd09c1753/state.go#L535

Anytime there is a mention of ping, I've added explicitly whether this is an UDP or TCP segment.