hashicorp / memberlist

Golang package for gossip based membership and failure detection
Mozilla Public License 2.0
3.61k stars 435 forks source link

Fix sending compound messages corruption when including messages larger than 64KB (PR #260 clone) #262

Open alvinlin123 opened 2 years ago

alvinlin123 commented 2 years ago

I am cloning PR #260 to address the review comments because original author of PR #260 doesn't seem to have time to address the review comments.

hashicorp-cla commented 2 years ago

CLA assistant check
All committers have signed the CLA.

Amier3 commented 2 years ago

Thanks for this @alvinlin123

We'll try to carve out some time to get this reviewed. Unfortunately the original reviewer is no longer working at Hashicorp so i'll need to pull in a quick second pair of eyes. Since this is just the revisions it won't be a full re-review

alvinlin123 commented 2 years ago

@Amier3 any luck finding someone to review?

alvinlin123 commented 2 years ago

@Amier3 any news ?

rohang98 commented 1 year ago

@Amier3 were you about to find someone to review this?

dastrobu commented 2 months ago

any update on this?