[DO-NOT-MERGE] Ensure messages in gossip function are the same for each node

hashicorp / memberlist

Golang package for gossip based membership and failure detection

Mozilla Public License 2.0

3.61k stars 435 forks source link

Closed jmurret closed 1 year ago

jmurret commented 1 year ago

This refactor addresses:

removing the getBroadcasts() call out of the message/node loop so that we avoid the potential case that one node gets a different set of messages than another. (and therefore infection rate is diminished because for a given message because not all 3 nodes are relaying it).
making sure that compound messages are not rebuilt for each node and we ensure they each get the same compound messages (and also less processing).

rboyer commented 1 year ago

LGTM, assuming you don't merge it.