search

hashicorp / next-remote-watch

Decorated local server for next.js that enables reloads from remote data changes
Mozilla Public License 2.0
353 stars 19 forks source link

Testing Coverage: Setup ESLint and Jest - preparation for Step 1 #20

Closed floroz closed 3 years ago

floroz commented 3 years ago

✅ Closes: #19

This PR introduces jest and eslint in the project.

It also introduces a Testing Strategy.

@jescalan I would like to introduce changes incrementally, therefore it would be great if you could create a dev branch and I can send all my PR against that one.

Please have a read at the Testing Strategy and let me know whether you have any question/concern.

hashicorp-cla commented 3 years ago

CLA assistant check
All committers have signed the CLA.

floroz commented 3 years ago

✅ Closes: #19

This PR introduces jest and eslint in the project.

It also introduces a Testing Strategy.

@jescalan I would like to introduce changes incrementally, therefore it would be great if you could create a dev branch and I can send all my PR against that one.

Please have a read at the Testing Strategy and let me know whether you have any question/concern.

I also wanted to add, if you are happy with the architecture/strategy, I can do Step 1 & 2 in one PR (it's easier to mock and manage dependencies when they are isolated in modules).

See below comment:

floroz commented 3 years ago

Hey @jescalan I have setup a PR draft for the follow up: https://github.com/floroz/next-remote-watch/pull/1

Would be nice if you could have a look and let me know your thoughts. If we get this current PR merged, I can submit a new PR with that branch and we can start addressing ideas/opinions around separation of concerns, file name, project structure, etc.

I am also working in tandem with @vicentereig and would be nice if we could submit a CONTRIBUTORS.md to include him, since the work is mostly coming from my GitHub account.