search

hashicorp / nomad-driver-lxc

HashiCorp Nomad LXC driver plugin
Mozilla Public License 2.0
31 stars 19 forks source link

Delete lxc container when task is destroyed #12

Closed towe75 closed 5 years ago

towe75 commented 5 years ago

This change introduces a new driver configuration parameter "destroy_containers" with a default value of true.

If it's true, then a LXC Container is now really deleted when a task is destroyed. If set to false, then the container is kept around indefinitely like in older versions.

hashicorp-cla commented 5 years ago

CLA assistant check
All committers have signed the CLA.

onlyjob commented 5 years ago

Hashicorp team, please merge it already. This change is required and necessary.

IMHO CLA is annoying and unnecessary. I would not sign it.

towe75 commented 5 years ago

@onlyjob well, i actually signed the CLA already in June but something is wrong with the bot. I did the commits with a different email adress and it complains that this is not a github user. Maybe i have to redo the PR with proper setup.

towe75 commented 5 years ago

Hmm. It does not build anymore on travis. I can see a different go version (1.13) compared to last try. @tgross do you have any hint, latest master build was a couple of month ago?

I will also contribute a go.mod based version with improved makefile and better linter etc. But it should be done in a separate PR, it's a bigger change and not related to the small feature in this PR.

tgross commented 5 years ago

Hmm. It does not build anymore on travis. I can see a different go version (1.13) compared to last try. @tgross do you have any hint, latest master build was a couple of month ago?

Yeah, unfortunately Nomad requires 1.12.x until we get some of the hairy details of go.mod worked out with our plugins and api nested modules.

tgross commented 5 years ago

This looks great, @towe75. Thanks for adding that test!