Fixes shm_size in config not getting recognized.

hashicorp / nomad-driver-podman

A nomad task driver plugin for sandboxing workloads in podman containers

https://developer.hashicorp.com/nomad/plugins/drivers/podman

Mozilla Public License 2.0

224 stars 61 forks source link

Fixes shm_size in config not getting recognized. #330

Closed rjthomas013 closed 3 months ago

rjthomas013 commented 3 months ago

Closes https://github.com/hashicorp/nomad-driver-podman/issues/305

hashicorp-cla commented 3 months ago

All committers have signed the CLA.

shoenig commented 3 months ago

@rjthomas013 looks like the linting step wants this change

==> Linting source code ...
Error: driver_test.go:1232:2: commentFormatting: put a space between `//` and comment text (gocritic)
    //set shm_size of 100m
make: *** [GNUmakefile:32: check] Error 1

rjthomas013 commented 3 months ago

@rjthomas013 looks like the linting step wants this change


==> Linting source code ...

Error: driver_test.go:1232:2: commentFormatting: put a space between `//` and comment text (gocritic)

  //set shm_size of 100m

make: *** [GNUmakefile:32: check] Error 1

Ok thanks. I will update the PR.