hashicorp / nomad-driver-podman

A nomad task driver plugin for sandboxing workloads in podman containers
https://developer.hashicorp.com/nomad/plugins/drivers/podman
Mozilla Public License 2.0
232 stars 62 forks source link

Static IP, IPv6 and MAC addresses with Podman >=4.0.0 #359

Open zandeez opened 4 months ago

zandeez commented 4 months ago

Resolve #293 and #358 adding ipv6_address, ipv4_address, static_ips and static_mac options for podman tasks.

Podman API version checks whether to set the properties directly or whether to use the new PerNetworkOptions framework.

ipv6_address and ipv4_address are provided for backwards compatibility, and for compatibility with docker. For Podman 4.0.0 these are merged into static_ips and sent as a PerNetorkOptions entry for the default network.

hashicorp-cla-app[bot] commented 4 months ago

CLA assistant check
All committers have signed the CLA.

hashicorp-cla-app[bot] commented 4 months ago

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Juanadelacuesta commented 1 month ago

Hello @zandeez, thank you for submitting this PR, My colleagues @shoenig or @gulducat have some expertise on that system, so I’d like to see what they might think of this.