'node_class' of a node is not affected by configuration reload

dvusboy commented 8 years ago

Nomad version

# nomad version
Nomad v0.4.0

Operating system and Environment details

# cat /etc/os-release
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"

CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7"

# uname -r
3.10.0-327.22.2.el7.x86_64

Issue

Update the nomad configuration file and change the value of node_class and then sending a SIGHUP to nomad does not change the run-time value of the node.

Reproduction steps

Modify the value of node_class in /etc/nomad/config.hcl, e.g.

client {
enabled = true
node_class = "default"
...

to

client {
enabled = true
node_class = "quantum"

Send SIGHUP to nomad with systemctl reload nomad

Confirmed the reload with systemctl status nomad; you should see:

Aug 05 12:13:36 <hostname> nomad[1550793]: ==> Reloading configuration...

Use nomad node-status -self to confirm the Class value did not change:

# nomad node-status -self
ID     = 3774c79c
Name   = <host>
Class  = default
DC     = rnd
Drain  = true
Status = ready
Uptime = 597h47m14s
...

Only a restart of nomad will cause the value to change.
Nomad Server logs (if appropriate)

# journalctl --no-pager --unit=nomad | egrep -A5 Reloading
Aug 05 12:13:36 <host> nomad[1550793]: ==> Reloading configuration...
Aug 05 12:13:36 <host> systemd[1]: Reloaded Nomad is a distributed, highly available, datacenter-aware scheduler.
Aug 05 12:13:36 <host> nomad[1550793]: http: Request /v1/agent/servers (98.579µs)
Aug 05 12:13:36 <host> nomad[1550793]: 2016/08/05 12:13:36 [DEBUG] http: Request /v1/agent/servers (98.579µs)
Aug 05 12:13:38 <host> nomad[1550793]: 2016/08/05 12:13:38 [DEBUG] http: Request /v1/jobs (3.395622ms)
Aug 05 12:13:38 <host> nomad[1550793]: http: Request /v1/jobs (3.395622ms)

akaspin commented 7 years ago

Nomad 0.5.1. Configs are not reloaded after SIGHUP.

dvusboy commented 7 years ago

Is this fixed in 0.5.5?

dadgar commented 7 years ago

No, only vault config on servers and logging is handled currently.

Thanks, Alex Dadgar

On Mar 17, 2017, 2:05 PM -0700, K.C. Wong notifications@github.com, wrote:

Is this fixed in 0.5.5?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub (https://github.com/hashicorp/nomad/issues/1525#issuecomment-287471039), or mute the thread (https://github.com/notifications/unsubscribe-auth/AA_9aut1zB-bFRywrWXmuIOCdUh-VUBFks5rmvWxgaJpZM4JeGIf).

hashicorp / nomad