search

hashicorp / nomad

Nomad is an easy-to-use, flexible, and performant workload orchestrator that can deploy a mix of microservice, batch, containerized, and non-containerized applications. Nomad is easy to operate and scale and has native Consul and Vault integrations.
https://www.nomadproject.io/
Other
14.9k stars 1.95k forks source link

draining system jobs toggle should not be enabled by default #17317

Open josh-m-sharpe opened 1 year ago

josh-m-sharpe commented 1 year ago

Client_ip-10-20-11-194_us-west-2_compute_internal_-_Nomad

Just a suggestion, but I think it'd be better if this was disabled by default. It's extremely destructive.

In my context, at least, an empty client with system jobs running is a good node. It "works". A drained node without system jobs can still very much be in the load balancer and then requests die.

tgross commented 1 year ago

I know this issue is about the UI but I think the UI is probably following the default behavior of the CLI. We also have https://github.com/hashicorp/nomad/issues/8622 open to discuss whether it makes sense to do there too.

josh-m-sharpe commented 1 year ago

Minor note here, seems like this drop down retains your previously-used settings. So if you previously drained system jobs, the next time you open the this dropdown that box will be checked.

So that's not quite mirroring the CLI.

But, I maintain it would better (as in safer) if I had to opt into system jobs every time.