Closed yazdan closed 10 months ago
It seems in csi definition this field is not optional https://github.com/container-storage-interface/spec/blob/master/csi.proto#L1131
Thanks for the follow-up @yazdan. This looks like a documentation miss and a bug in the CLI (it should validate the field is set before bothering to send the request).
@tgross I can submit a PR to correct this. Please let me know
Sure, go for it!
Doing some issue cleanup and this was fixed in https://github.com/hashicorp/nomad/pull/17958, which shipped in Nomad 1.6.2
I deployed nomad lab on my local machine with 2 node nomad cluster on vms and 3rd vm as Truenas scale.
Nomad version
Operating system and Environment details
democratic-csi
. Both controller and node jobs using nfs configuration, I followed this guide and used nfs configuration instead.Issue
I you try to create volume snapshot without providing
sanpshot_name
it gives an errorbut if you provide the
sanpshot_name
it will create theReproduction steps
Enable
democratic-csi
and try to create a nameless snapshotExpected Result
Snapshot is created as the
sanpshot_name
is optionalActual Result
error
Job file
not applicable
Nomad Server logs
PS: I checked the code and it seems that in the code
name
is not optional but mandatory https://github.com/hashicorp/nomad/blob/a9f52f540e81ff152574a97c12b011c605d423f8/plugins/csi/plugin.go#L724