search

hashicorp / nomad

Nomad is an easy-to-use, flexible, and performant workload orchestrator that can deploy a mix of microservice, batch, containerized, and non-containerized applications. Nomad is easy to operate and scale and has native Consul and Vault integrations.
https://www.nomadproject.io/
Other
14.87k stars 1.95k forks source link

packaging: Add dmidecode as a Suggested / Recommended package to Nomad's Linux packaging manifest. #19382

Open shoenig opened 10 months ago

shoenig commented 10 months ago

Add dmidecode as a Suggested / Recommended package to Nomad's Linux packaging manifest.

Nomad 1.7 and later relies on the dmidecode command being available particularly in virtualized environments like Amazon EC2 for the detection of CPU performance data.

Not having this as part of the Linux packaging creates a bad UX for first starting up a Nomad 1.7 agent in these environments, e.g.

https://github.com/hashicorp/nomad/issues/19343 https://github.com/hashicorp/nomad/issues/19371

apollo13 commented 10 months ago

I'd recommend (pun intended) to put it into the recommended section and not suggested. Recommended is usually (not always though) installed by default whereas suggested is usually not installed and also not seen by the user. Then again if this is only required for virtualized systems it might not make sense to install by default but solely error out in the nomad agent and as such communicating the problem clearly to the user. On the other hand I'd imagine virtual machines are probably more common than bare metal nowadays for nomad, so it still might make sense to install dmidecode by default via a dependency.

ahjohannessen commented 10 months ago

Flatcar Linux does not seem to have dmidecode - Fedora CoreOS can get it via rpm-ostree. Wonder how I should go about this with my Flatcar machines.

MorphBonehunter commented 10 months ago

I'm not convinced that installing dmidecode should be adviced as this could lead to suboptimal MHz readings (#19468) in virtual machine environments. So that's maybe also a point to rethink reopening #18213.