search

hashicorp / nomad

Nomad is an easy-to-use, flexible, and performant workload orchestrator that can deploy a mix of microservice, batch, containerized, and non-containerized applications. Nomad is easy to operate and scale and has native Consul and Vault integrations.
https://www.nomadproject.io/
Other
14.57k stars 1.92k forks source link

Unable to filter by node pool after update to v1.8.1 #23445

Closed gscho closed 1 day ago

gscho commented 2 weeks ago

Nomad version

v1.8.1

Issue

After updating to version 1.8.1 I can no longer filter by node pool in the nomad UI. When I select any node pool I see an error like this:

No jobs match your current filter selection: (NodePool == windows-amd64-instance-production). failed to create result paginator: failed to read filter expression: 1:21 (20): rule "grouping": Unmatched parentheses

Note this is only for node pools and all other filters I've tried seem to work fine.

Reproduction steps

Select a node pool filter from the drop down or search for (NodePool == my-pool) in the search bar.

Expected Result

Actual Result

thefallentree commented 2 weeks ago

we ran into same issue, and it's because the filter code doesn't work with "-" in the pool name, the JS needs to add quotes around the pool name

tgross commented 2 weeks ago

Thanks for the debugging there @thefallentree! I'll mark this for the attention or our UI folks.

philrenaud commented 1 day ago

This should be fixed by a change in #23468 — thanks for opening the issue and for your patience!