[feature] notify systemd after agent has joined the cluster

hashicorp / nomad

Nomad is an easy-to-use, flexible, and performant workload orchestrator that can deploy a mix of microservice, batch, containerized, and non-containerized applications. Nomad is easy to operate and scale and has native Consul and Vault integrations.

https://www.nomadproject.io/

Other

14.87k stars 1.95k forks source link

[feature] notify systemd after agent has joined the cluster #4466

Closed jrasell closed 2 months ago

jrasell commented 6 years ago

In the same style that Consul integrated, it would be nice if Nomad could have the potential to notify systemd when the agent has successfully joined the cluster and is operational. This would allow dependant services to be correctly chained off Nomad rather than blindly starting assuming the service is OK.

Consul PR - https://github.com/hashicorp/consul/commit/31a310f551c36243d2aae9ed80054c200e079b81 Consul Issue - https://github.com/hashicorp/consul/issues/2121

I am happy to raise a PR for this if you believe its a worthwhile addition but have a few questions:

preference on importing the Consul implementation systemd package or writing a custom Nomad one
exactly where successful startup and join of an agent would be considered for notification

nickethier commented 6 years ago

Hey @jrasell

Thanks for raising this issue. I'd advise holding off on any immediate work as there some work in progress that could affect this. I think this may benefit from some work we're doing to support external plugins. This is a valuable use case to identify and will help add perspective.

jippi commented 5 years ago

@nickethier any news on this?

stale[bot] commented 5 years ago

Hey there

Since this issue hasn't had any activity in a while - we're going to automatically close it in 30 days. If you're still seeing this issue with the latest version of Nomad, please respond here and we'll keep this open and take another look at this.

Thanks!

jrasell commented 5 years ago

Please keep open.

elcomtik commented 2 years ago

@nickethier any news?

I have an issue with dependency for vault-agent and experiencing exactly this issue https://github.com/hashicorp/nomad/issues/3885

I'm reloading nomad by vault-agent service, so I wanted to patch this by defining systemd service order. However, this is useless because the systemd unit for nomad is using Type simple, which doesn't wait for service startup. I tried to use types forking and notify, however, nomad doesn't support them also.

Support for proper systems notification is essential for proper integration with vault-agent which reloads nomad for ACL token renewal. This makes life with enabled ACL unnecessarily hard.

elcomtik commented 1 year ago

Support for proper systems notification is essential for proper integration with vault-agent which reloads nomad for ACL token renewal. This makes life with enabled ACL unnecessarily hard.

@tgross This still bothers me, are there any plans for it? Thanks for your response.

tgross commented 2 months ago

Shipped in Nomad 1.8.0: https://github.com/hashicorp/nomad/pull/20528