search

hashicorp / packer-plugin-alicloud

Packer plugin for Alibaba Cloud Image Builder
https://www.packer.io/docs/builders/alicloud-ecs
Mozilla Public License 2.0
12 stars 21 forks source link

support setting ImageFamily and BootMode when building image #140

Closed hwhuangzsly closed 4 months ago

hwhuangzsly commented 4 months ago

support setting ImageFamily and BootMode when building image

hashicorp-cla-app[bot] commented 4 months ago

CLA assistant check
All committers have signed the CLA.

hwhuangzsly commented 4 months ago

@lbajolet-hashicorp Thanks for your suggestions. I have added tests to the "target_image_family" and "boot_mode", and optimize the verification method and description of the "target_image_family". Please take a review again~

lbajolet-hashicorp commented 4 months ago

The last reroll looks good to me @hwhuangzsly, thanks for pushing this one forward!

I'll wait for tests to go green and merge this.

hwhuangzsly commented 4 months ago

@lbajolet-hashicorp Excuse me, do you know when the next release version will be made?

lbajolet-hashicorp commented 4 months ago

Hi @hwhuangzsly,

This can happen reasonably soon I would think, maybe today or tomorrow.

I'll let you know when this happens

hwhuangzsly commented 4 months ago

@lbajolet-hashicorp Excuse me, as we previously mentioned, the next release version will be made soon. I think maybe you forget it, just a gentle reminder.

lbajolet-hashicorp commented 4 months ago

Hi @hwhuangzsly,

Thanks for the reminder, I did forget indeed. I've opened a PR for starting this release, provided this is accepted and merged quickly, the release will follow soon after.