search

hashicorp / packer-plugin-alicloud

Packer plugin for Alibaba Cloud Image Builder
https://www.packer.io/docs/builders/alicloud-ecs
Mozilla Public License 2.0
12 stars 21 forks source link

Add minimum RAM permission for the doc #84

Closed binkesi closed 1 year ago

binkesi commented 2 years ago

Hi team, when I try to use packer plugin for Alicloud, I found these are the minimum RAM permission for it to call the Alicloud APIs. Please have a review, thanks.

hashicorp-cla commented 2 years ago

CLA assistant check
All committers have signed the CLA.

nywilken commented 1 year ago

@binkesi thank you for the documentation update. I would love to get this change in. Could you take a minute to sign the CLA. If it has already been signed please check that your primary GitHub email, as well as the email in the commit, matches the email you signed the CLA with.

binkesi commented 1 year ago

@binkesi thank you for the documentation update. I would love to get this change in. Could you take a minute to sign the CLA. If it has already been signed please check that your primary GitHub email, as well as the email in the commit, matches the email you signed the CLA with.

Thank you! You're right, I found that the Github Email I used for commit is just another email. So should I close this PR and use one same Github email to reopen another PR?

nywilken commented 1 year ago

@binkesi seeing as you only have one commit you can manually change your author email on your fork and force push your changes. I found a small blog post illustrating how to change your email https://dev.to/brayanarrieta/how-to-change-the-git-commit-author-56mg.

If its easier to close and reopen with a new branch using the updated email that is fine too.

binkesi commented 1 year ago

@nywilken Yeah, it work well! Please help to review. Thank you!

nywilken commented 1 year ago

@binkesi thanks for working through the CLA bot checks.