search

hashicorp / packer-plugin-azure

Packer plugin for Azure Virtual Machine Image Builders
https://www.packer.io/docs/builders/azure
Mozilla Public License 2.0
47 stars 76 forks source link

ARM Builder: Windows builds default to SSH communicator type when communicator is unset #422

Open JenGoldstrich opened 3 weeks ago

JenGoldstrich commented 3 weeks ago

Similar to https://github.com/hashicorp/packer-plugin-azure/issues/415

Whenever the communicator field is unset Windows will try to connect via SSH instead of WinRM, this fails because SSH on Windows is not configured to work by default.

This happens because of this logic in the packer-plugin-sdk https://github.com/hashicorp/packer-plugin-sdk/blob/9c1d2437dcbde2571b2a8f5d8ce280dce76a377b/communicator/config.go#L461-L463

To solve this either force users to specify a communicator, or forcibly override the default to WinRM for Windows builds, this would need to be done before this Prepare call https://github.com/hashicorp/packer-plugin-azure/blob/738e7aefc89609a33d0139e1fc838825aac1f05e/builder/azure/arm/config.go#L874-L875