search

hashicorp / packer-plugin-docker

Packer plugin for Docker Builder
https://www.packer.io/docs/builders/docker
Mozilla Public License 2.0
30 stars 26 forks source link

Delete docs/README.md #21

Closed sylviamoss closed 3 years ago

sylviamoss commented 3 years ago

This breaks the remote docs pull out.

nywilken commented 3 years ago

Oh good catch. Pining @jescalan and @zchsh here. I thought that remote docs setup would only process .mdx files. But I'm guessing that this is probably triggering a validation check failure.

zchsh commented 3 years ago

@nywilken Confirmed, I think a possibly-too-strict validation check may be the issue here - right now I believe we only pass the check if there are exclusively .mdx files in the expected component subfolders. We can definitely ignore extra files rather than throw a validation error when they're present.

Would we want to ignore all extra files, or just extra .md files?

nywilken commented 3 years ago

Fix for README has been made in hashicorp/packer closing this PR.