search

hashicorp / packer-plugin-googlecompute

Packer plugin for Google Compute Builder
https://www.packer.io/docs/builders/googlecompute
Mozilla Public License 2.0
23 stars 51 forks source link

Add architecture support to googlecompute-import post-processor #147

Closed anish closed 1 year ago

anish commented 1 year ago

Allows specifying architecture when running googlecompute-import post-processor, essentially allowing you to specify arm64 or x86_64. Defaults to the current value of ARCHITECTURE_UNSPECIFIED

Note : this required updating the google compute api modules, I'm not sure if those changes are acceptable as part of this PR or they need to be separated out

anish commented 1 year ago

@nywilken could I get a review on this ?

anish commented 1 year ago

@nywilken ping

anish commented 1 year ago

@lbajolet-hashicorp no worries. I can take care of the rebase, but could someone help with the go module updates ? I'm not sure what the process for doing that is (specifically cloud.google.com/go/compute/metadata)

lbajolet-hashicorp commented 1 year ago

I can probably help with those! Let me know when you rebased on top of main, and I'll take a look at the mod/sum files, thanks!

anish commented 1 year ago

@lbajolet-hashicorp rebased. I've dropped the go mod changes for now, they seem to be not required after rebase