GitHub Actions - deprecated warnings found - action required!

[sarahethompson]

Workflow Name: Acceptance Test Branch: main Run URL: https://github.com/hashicorp/packer-plugin-googlecompute/actions/runs/4964028146

save-state deprecation warnings: 0 set-output deprecation warnings: 1 node12 deprecation warnings: 2

Please review these deprecation warnings as soon as possible and merge in the necessary updates.

GitHub will be removing support for these commands and plan to fully disable them on 31st May 2023. At this time, any workflow that still utilizes these commands will fail. See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/.

GitHub have not finalized a date for deprecating node12 yet but have indicated that this will be summer 2023. So it is advised to switch to node16 asap. See https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

If you need any help, please reach out to us in #team-rel-eng.

[tbehling]

There's a proposed PR at https://github.com/hashicorp/packer-plugin-googlecompute/pull/166

[lbajolet-hashicorp]

Hi @tbehling @sarahethompson,

Most of the workflows are maintained through TFC for the plugin repos, so we'll have to change some here. Out of curiosity, which action still uses Node 12? Most of the checkout updates move from v2 to v3.5.1, we already bumped a majority of those to 3.5.0 on the repository that manages those, so I presume they are already using a more recent version of NodeJS.

I see that the original message highlights 3 issues in our workflows, but it doesn't say which ones are the problem, any chance we can see what those violations are?

[sarahethompson]

Hey @lbajolet-hashicorp - you should be able to see more details if you scroll down in the workflow run linked above ^ (https://github.com/hashicorp/packer-plugin-googlecompute/actions/runs/4964028146) - all our automation is doing is scanning the last few runs of every workflow to see if there are any warnings like these. I'm not sure how your repo gets the updates from TFC but there are still a lot actions in this repo (Acceptance Test workflow) still using checkout@v2 and setup-go@v2 which are what seem to have caused the warnings in the last run.

[lbajolet-hashicorp]

Oh that's fair, I thought that because it was referencing one of our workflows it was a typoed link :sweat_smile:

I'll take a look at this on all our plugins this afternoon and fix that. I'll do another round of checks on the repo that manages some of those files, and fix the remaining issues at the same time.

For reference, acceptance tests are not managed through TFC, that's one that is specific to this repo, the build-* ones are however (and some others but I can't enumerate them all by memory, hope you understand :smile:)