search

hashicorp / packer-plugin-googlecompute

Packer plugin for Google Compute Builder
https://www.packer.io/docs/builders/googlecompute
Mozilla Public License 2.0
23 stars 53 forks source link

Migrate to new Google Cloud impersonation API #84

Closed fgateuil closed 2 years ago

fgateuil commented 2 years ago

I updated the code using the non-deprecated way of using Google Cloud IAM impersonation.

Despite my efforts, I've been unable to submit any relevant unit tests since this part of the code is tied to Google remote API (POST requests are performed). I tried to invoke/create mocking objects without success.

As a result, I think that this should be tested with integration tests but it looks like nothing similar exists yet (it would probably be quite expensive to have a dedicated GCP project).

Nevertheless, I would be more than happy if someone could help me on that. Hope my contribution will be helpful.

Closes #83

hashicorp-cla commented 2 years ago

CLA assistant check
All committers have signed the CLA.

fgateuil commented 2 years ago

If everything is now ok for you @azr, feel free to merge the PR ;) Thanks.