hashicorp / packer-plugin-hyperv

Packer plugin for Hyper-V Builder
https://www.packer.io/docs/builders/hyperv
Mozilla Public License 2.0
19 stars 24 forks source link

Enable `secondary_iso_images` to Retrieve and Checksum ISO Images just like `iso_url` #136

Open GuyEP-Modulate opened 1 month ago

GuyEP-Modulate commented 1 month ago

Community Note

Please vote on this issue by adding a šŸ‘ reaction to the original issue to help the community and maintainers prioritize this request. Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request. If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

I like that iso_url uses Go-Getter to fetch and optionally checksum an ISO, but find it strange that secondary_iso_images does not have the same features. Rather, it seems like this just gets piped directly into Hyper-V as other ISOs to mount.

Use Case(s)

  1. Installing additional software from the internet or a network share.
  2. Wanting to ensure that software being installed has the same checksum as when you wrote the template, especially since the software is likely being installed from an elevated session in Windows or root session in Linux, where it would be vulnerable to a supply chain attack.

Potential configuration

Either parse the secondary_iso_images variable through the same code that handles iso_url or provide a new option called secondary_iso_image_urls that are processed through Go-Getter and can get appended to the ISO URLs passed into Hyper-V if they are provided.

Potential References