Closed gitmkn closed 6 months ago
1、role_arn/session_name/session_duration合并成struct 2、profile默认”default“ 3、文档自动生成,不应该手写 4、支持创建的时候传入cam_role_name 5、加上单测
@nywilken Please help view the pull request.
@lbajolet-hashicorp @nywilken Please help review the PR.
@lbajolet-hashicorp @nywilken Please help review the PR.
@hellertang thanks for bubbling this change up. It looks like you've been actively engaged with this change. Thank you. Given your knowledge of the plugin and Tencent Cloud I will defer to your approve on the changes. Can you please validate that the code works as expected, and that each of the supported authorization components are properly documented.
I see there are a few references to Terraform, which I suspect was ported over from the Terraform provider. Can you please update the text to read as Packer.
That said, we will gladly merge and release once you have validated the functionality and given your verbal approve of the changes via a comment. FWIW we do not have the infrastructure for testing.
@hellertang thanks for bubbling this change up. It looks like you've been actively engaged with this change. Thank you. Given your knowledge of the plugin and Tencent Cloud I will defer to your approve on the changes. Can you please validate that the code works as expected, and that each of the supported authorization components are properly documented.
I see there are a few references to Terraform, which I suspect was ported over from the Terraform provider. Can you please update the text to read as Packer.
That said, we will gladly merge and release once you have validated the functionality and given your verbal approve of the changes via a comment. FWIW we do not have the infrastructure for testing.
I am immensely delighted to receive your response, and I extend my apologies for the delayed reply, as I overlooked the message. In the forthcoming week, I shall meticulously validate this submission locally, while simultaneously working with the submitter to enhance this document. Thanks again!
Hi @nywilken ,
First and foremost, we have removed all descriptions related to Terraform from the documentation, thank you for your reminder.
Next, allow me to summarize the key aspects of this update. There are primarily four aspects:
Lastly, I have conducted local tests using four setting methods:
And I am confident that the required images are created as expected in each case.
Kindly assist in confirming whether there are any remaining issues. If none are present, please help merge this PR.
Thanks Again!
Hi @nywilken ,
First and foremost, we have removed all descriptions related to Terraform from the documentation, thank you for your reminder.
Next, allow me to summarize the key aspects of this update. There are primarily four aspects:
- support for setting temporary tokens
- support for setting role ARNs
- support for setting profiles
- optimization of documentation content to ensure auto-generated documents.
Lastly, I have conducted local tests using four setting methods:
- AK/SK
- temporary tokens
- profiles
- role ARNs
And I am confident that the required images are created as expected in each case.
Kindly assist in confirming whether there are any remaining issues. If none are present, please help merge this PR.
Thanks Again!
@nywilken Please help review the PR. Thanks again!
Hello there - just wanted to follow up on this change to see where you sit with the feedback. Please let me know if you prefer I just merge and release.
Hello there - just wanted to follow up on this change to see where you sit with the feedback. Please let me know if you prefer I just merge and release.
I apologize for the late response, as the progress was delayed due to other matters. Thank you very much for your suggestions. We have made the necessary fixes under your guidance and ensured that all tests have passed. Please kindly confirm if there are any remaining issues. If there are none, please proceed with merging and releasing the package.
Thanks Again! @nywilken
Thanks for working to update this change. It looks like there are a few failing tests and lint checks. Could you please remedy those issues so that I can get this merged and released please.
Thanks for working to update this change. It looks like there are a few failing tests and lint checks. Could you please remedy those issues so that I can get this merged and released please.
Thank you for your reminder. The issues identified during the inspection have been resolved. Please kindly verify once more. Thanks Again! @nywilken
@nywilken Please help review the PR again.
Thank you for merging the changes. Please kindly release a new version to incorporate this update. @nywilken Thanks Again!