search

hashicorp / packer-plugin-tencentcloud

Packer plugin for Tencent Cloud Image Builder
https://www.packer.io/docs/builders/tencentcloud-cvm
Mozilla Public License 2.0
8 stars 12 forks source link

support TCE(Tencent Cloud Enterprise) #87

Closed JinXingYoung closed 1 year ago

JinXingYoung commented 1 year ago

To add support for Tencent Cloud Enterprise

hashicorp-cla commented 1 year ago

CLA assistant check
All committers have signed the CLA.

JinXingYoung commented 1 year ago

@nywilken @likexian Could you please help to review this ?

likexian commented 1 year ago

LGTM

@azr Please help processing.

JinXingYoung commented 1 year ago

LGTM

@azr Please help processing.

@azr Please help processing this pr, thanks!

JinXingYoung commented 1 year ago

@nywilken @lbajolet-hashicorp @JenGoldstrich Could you please help processing this pr, thanks ^^

JinXingYoung commented 1 year ago

Hi @JinXingYoung,

Sorry for taking so long to review your PR, I've done a pass and I have a few things that popped to mind, but aside from these concerns, the code looks good to me.

When the comments I left are addressed, we can consider merging this.

Thanks, and sorry again for the delay.

It doesn't matter, and thank you very much for the review comments, they are all useful suggestions, I will optimize these points.

JinXingYoung commented 1 year ago

With the extra check for the endpoints, and the error check for url.Parse, it's good for me, I'll merge this. Thanks for the reroll @JinXingYoung! @lbajolet-hashicorp Thanks to merge! Is this modification available for packer 1.8.6? May I ask when it will be released?

lbajolet-hashicorp commented 1 year ago

Hi @JinXingYoung,

Since this is the Tencent Cloud plugin, it's independent from Packer itself.

Given that we haven't released a version of this plugin for a while, we can probably schedule one for next week, you'll then be able to update the version of the plugin for your use case.

For reference, you can specify which version of the plugin to use for building a template through the packer block (SEE: https://developer.hashicorp.com/packer/docs/templates/hcl_templates/blocks/packer#specifying-plugin-requirements).

JinXingYoung commented 1 year ago

@lbajolet-hashicorp Got it, thanks!