Closed JinXingYoung closed 1 year ago
@nywilken @likexian Could you please help to review this ?
LGTM
@azr Please help processing.
LGTM
@azr Please help processing.
@azr Please help processing this pr, thanks!
@nywilken @lbajolet-hashicorp @JenGoldstrich Could you please help processing this pr, thanks ^^
Hi @JinXingYoung,
Sorry for taking so long to review your PR, I've done a pass and I have a few things that popped to mind, but aside from these concerns, the code looks good to me.
When the comments I left are addressed, we can consider merging this.
Thanks, and sorry again for the delay.
It doesn't matter, and thank you very much for the review comments, they are all useful suggestions, I will optimize these points.
With the extra check for the endpoints, and the error check for
url.Parse
, it's good for me, I'll merge this. Thanks for the reroll @JinXingYoung! @lbajolet-hashicorp Thanks to merge! Is this modification available for packer 1.8.6? May I ask when it will be released?
Hi @JinXingYoung,
Since this is the Tencent Cloud plugin, it's independent from Packer itself.
Given that we haven't released a version of this plugin for a while, we can probably schedule one for next week, you'll then be able to update the version of the plugin for your use case.
For reference, you can specify which version of the plugin to use for building a template through the packer
block (SEE: https://developer.hashicorp.com/packer/docs/templates/hcl_templates/blocks/packer#specifying-plugin-requirements).
@lbajolet-hashicorp Got it, thanks!
To add support for Tencent Cloud Enterprise