hashicorp / packer-plugin-virtualbox

Packer plugin for VritualBox Builder
https://www.packer.io/docs/builders/virtualbox
Mozilla Public License 2.0
22 stars 36 forks source link

fix doc links #126

Closed jcrben closed 5 months ago

jcrben commented 6 months ago

These links are broken, so this fixes them.

Reproduction:

Verify fix:

hashicorp-cla commented 6 months ago

CLA assistant check
All committers have signed the CLA.

nywilken commented 5 months ago

Hi @jcrben thanks for change. The links in the README are configured for the integration portal on https://developer.hashicorp.com/packer/integrations/hashicorp/virtualbox

I understand how this can be confusing when trying to read the documents on GitHub. Plugin documents contain a number of generation steps and partials, which then get pushed into .web-docs for final deployment on the integration portal.

I closed this PR, as this is the expected behavior. But feel free to open an issue if you wish to discuss this further. I do wonder if there is a flow we can introduce for converting the links upon generation 🤔