Closed powertim closed 9 months ago
Hi, I've already signed the CLA... It's still blocked on this page. Feel free to contact me.
Hi @powertim,
Regarding the CLA problem, I believe this is because your commits have been pushed with an email that is not the one used for your Github account.
Can you change this in your commit chain? For the bot to be happy, all your commit should be authored with the email address linked to your Github account, then that should work out fine.
I'll review the code once you've had a chance to fix that, please let me know if you need more help.
Thanks for the contribution!
@powertim - could you rebase this from main
, please.
Marking as draft.
@powertim I've got some code that's similar but:
cdrom_type
base on what's provided or the default if notI'm testing it tom make sure it works as expected based on the above.
If you can rebase this PR, I can cherry-pick your commits and then merge in mine some you still get credit.
@powertim I've got some code that's similar but:
- uses the same
cdrom_type
base on what's provided or the default if not- removes the hardcoded vmtools path (not all host will have this)
- performs a configuration prior to running the build to fail early
- improved logging
I'm testing it tom make sure it works as expected based on the above.
If you can rebase this PR, I can cherry-pick your commits and then merge in mine some you still get credit.
Hi @tenthirtyam I've tried to make all things right. Could you confirm please ? Thanks and sorry for the "strange code" submitted on this PR, I was trying to make this feature quickly available on mainstream. Have a nice day,
Tim.
Yes, looks good I can cherry-pick this and merge my changes. i just want to run some negative test cases first.
Cherry-picked into #327.
I added a parameter named _keep_one_cdrom_ as boolean to permit the add of 1 SATA controller with 1 SATA CD-ROM drive after all drives are deleted.
Modifications are included in the step_remove_cdrom.go file:
Closes #24