search

hashicorp / packer-plugin-vsphere

Packer plugin for VMware vSphere Builder
https://www.packer.io/docs/builders/vsphere
Mozilla Public License 2.0
93 stars 91 forks source link

docs: update `disk_size` from mb to mib #349

Closed tenthirtyam closed 6 months ago

tenthirtyam commented 7 months ago

Closes #348 

packer-plugin-vsphere on docs/mb-to-mib
➜ go fmt ./...         

packer-plugin-vsphere on docs/mb-to-mib
➜ make build

packer-plugin-vsphere on docs/mb-to-mib
➜ export PATH=$PATH:$(go env GOPATH)/bin

packer-plugin-vsphere on docs/mb-to-mib
➜ make generate
2023/12/19 15:34:42 Copying "docs" to ".docs/"
2023/12/19 15:34:42 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vsphere on docs/mb-to-mib took 34.4s 
➜ make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        1.846s
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       2.342s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       5.729s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  2.702s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   5.014s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       1.506s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      2.030s
lindhe commented 7 months ago

I think the changes looks good. My only comments are on the PR title:

  1. It should probably say "from MB to MiB" instead of "from mb to mib", just for consistency.
  2. There are some other changes that are not reflected by the PR title. I don't think it's necessary break this up into into multiple PRs, so perhaps a simple addition of "and other changes" is good enough.

Please at least consider the first point. Apart from that, LGTM and I think it can be merged. Great job! 💪

tenthirtyam commented 7 months ago

I always use lowercase conventional commits unless it specifies a file name. :)