search

hashicorp / packer-plugin-vsphere

Packer plugin for VMware vSphere Builder
https://www.packer.io/docs/builders/vsphere
Mozilla Public License 2.0
93 stars 91 forks source link

feat: add support for precision clock device #367

Closed xtalkme closed 4 months ago

xtalkme commented 4 months ago

These changes allow you to define a VirtualPrecisionClock device.

Reference

Closes #354

Tests

From @tenthirtyam 

packer-plugin-vsphere on  pr/367 [⇕$!] via 🐹 v1.22.0 
➜ go get

packer-plugin-vsphere on  pr/367 [⇕$!] via 🐹 v1.22.0 took 3.0s 
➜ go mod tidy

packer-plugin-vsphere on  pr/367 [⇕$!] via 🐹 v1.22.0 
➜ go fmt builder/vsphere/driver/vm.go 

packer-plugin-vsphere on  pr/367 [⇕$!] via 🐹 v1.22.0 
➜ go fmt builder/vsphere/driver/vm_test.go 

packer-plugin-vsphere on  pr/367 [⇕$!] via 🐹 v1.22.0 
➜ go fmt builder/vsphere/common/step_hardware.go 

packer-plugin-vsphere on  pr/367 [⇕$!] via 🐹 v1.22.0 
➜ go fmt builder/vsphere/common/step_hardware_test.go 

packer-plugin-vsphere on  pr/367 [⇕$!] via 🐹 v1.22.0 
➜ make generate
2024/02/26 14:26:48 Copying "docs" to ".docs/"
2024/02/26 14:26:48 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vsphere on  pr/367 [⇕$!] via 🐹 v1.22.0 took 41.1s 
➜ make build

packer-plugin-vsphere on  pr/367 [⇕$!] via 🐹 v1.22.0 
➜ make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        8.858s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       4.369s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       15.168s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  6.187s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   20.340s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       12.214s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      14.876s
hashicorp-cla commented 4 months ago

CLA assistant check
All committers have signed the CLA.

tenthirtyam commented 4 months ago

I've corrected the CI issues, updated the description, and squashed the commits.

Results attached in the Tests section.

xtalkme commented 4 months ago

This MR started like i sorta knew what i was doing. That escalated quickly... Thanks for your help!

tenthirtyam commented 4 months ago

Nah, great job in adding the capability. This contribution is most welcome. In fact, there is a need to do the same in the Terraform provider, too. :)