search

hashicorp / packer-plugin-vsphere

Packer plugin for VMware vSphere Builder
https://www.packer.io/docs/builders/vsphere
Mozilla Public License 2.0
93 stars 91 forks source link

common: make sure to prepend remote iso path #388

Closed Hi-Angel closed 4 months ago

Hi-Angel commented 4 months ago

This fixes regression introduced by the commit

 "common: deduplicate AddCdrom call by appending path to ISOPaths"

that was squashed into:

 "refactor: only add / remove minimul number of cdroms (#355)"

It explained that the order is not guaranteed and does not matter, however the documentation says:

If the "iso_url" is defined in addition to the "iso_paths", the "iso_url" is added to the VM first. This keeps the "iso_url" first in the boot order by default allowing the boot iso being defined by the iso_url and the vmware tools iso added from the datastore.

So fix the regression.

Fixes: https://github.com/hashicorp/packer-plugin-vsphere/issues/386

Hi-Angel commented 4 months ago

upd: added the S-b to the commit message

tenthirtyam commented 4 months ago

@lbajolet-hashicorp @nywilken