search

hashicorp / packer-plugin-vsphere

Packer plugin for VMware vSphere Builder
https://www.packer.io/docs/builders/vsphere
Mozilla Public License 2.0
93 stars 91 forks source link

chore: staticcheck lint #435

Closed tenthirtyam closed 1 month ago

tenthirtyam commented 1 month ago

Summary

Addressed all issues observed by staticcheck.

Testing

packer-plugin-vsphere on  chore/staticcheck [!] via 🐹 v1.22.3 
➜ go fmt ./...     

packer-plugin-vsphere on  chore/staticcheck [!] via 🐹 v1.22.3 
➜ staticcheck ./...

packer-plugin-vsphere on  chore/staticcheck [!] via 🐹 v1.22.3 
➜ make generate    
2024/05/15 20:50:39 Copying "docs" to ".docs/"
2024/05/15 20:50:39 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vsphere on  chore/staticcheck [!] via 🐹 v1.22.3 took 12.4s 
➜ make build       

packer-plugin-vsphere on  chore/staticcheck [!] via 🐹 v1.22.3 took 4.3s 
➜ make test        
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        2.646s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       2.501s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       5.466s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  1.473s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   5.056s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       2.311s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      3.390s

packer-plugin-vsphere on  chore/staticcheck [!] via 🐹 v1.22.3 took 7.9s 
➜
tenthirtyam commented 1 month ago

All addressed!

lbajolet-hashicorp commented 1 month ago

LGTM, thanks for the many rerolls @tenthirtyam!

Merging now