search

hashicorp / packer-plugin-vsphere

Packer plugin for VMware vSphere Builder
https://www.packer.io/docs/builders/vsphere
Mozilla Public License 2.0
94 stars 91 forks source link

feat: add sata controller #451

Closed tenthirtyam closed 1 month ago

tenthirtyam commented 1 month ago

Description

Testing

packer-plugin-vsphere on ๎‚  feat/add-sata-controller [!] via ๐Ÿน v1.22.5 
โžœ go get github.com/vmware/govmomi@57aea68935dca95a7bb8f73c3ffb4b9905753861
go: downgraded github.com/vmware/govmomi v0.38.0 => v0.31.1-0.20240708220642-57aea68935dc

packer-plugin-vsphere on ๎‚  feat/add-sata-controller [!] via ๐Ÿน v1.22.5 
โžœ make build

Update Test: TestAddStorageDevices

func TestAddStorageDevices(t *testing.T) {
    config := &StorageConfig{
        DiskControllerType: []string{"sata"},
        Storage: []Disk{
            {
                DiskSize:            3072,
                DiskThinProvisioned: true,
                ControllerIndex:     0,
            },
            {
                DiskSize:            20480,
                DiskThinProvisioned: true,
                ControllerIndex:     0,
            },
        },
    }
...
packer-plugin-vsphere on ๎‚  feat/add-sata-controller [!] via ๐Ÿน v1.22.5 
โžœ make test                                                                
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        1.685s
?       github.com/hashicorp/packer-plugin-vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       4.820s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       7.458s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  4.856s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   9.294s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       3.686s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      4.633s
Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAddStorageDevices$ github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver

ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver   (cached)
Starting: /Users/johnsonryan/go/bin/dlv dap --listen=127.0.0.1:59579 --log-dest=3 from /Users/johnsonryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Work/packer-plugin-vsphere/builder/vsphere/driver
DAP server listening at: 127.0.0.1:59579
Type 'dlv help' for list of commands.
PASS
Process 96747 has exited with status 0
Detaching
dlv dap (95836) exited with code: 0

Reference

Closes #42

tenthirtyam commented 1 month ago

CI failures are expected until the upstream is merged, released, and this go.mod updated.