hashicorp / packer

Packer is a tool for creating identical machine images for multiple platforms from a single source configuration.
http://www.packer.io
Other
15.06k stars 3.32k forks source link

Cleanup lint codebase #13110

Closed lbajolet-hashicorp closed 2 months ago

lbajolet-hashicorp commented 2 months ago

This PR is a collection of fixups for linters run by golangci-lint. With this, we should be able to run golangci-lint on the whole codebase as all smells are eliminated.

nywilken commented 2 months ago

Should, and can, this be back ported to the 1.11.x branch?

lbajolet-hashicorp commented 2 months ago

I don't see a reason why this couldn't! I'll add the backport label

github-actions[bot] commented 1 month ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.