search

hashicorp / packer

Packer is a tool for creating identical machine images for multiple platforms from a single source configuration.
http://www.packer.io
Other
15.12k stars 3.33k forks source link

Backport of hcp: don't continue if HEAD doesn't exist into release/1.11.x #13166

Closed hc-github-team-packer closed 2 months ago

hc-github-team-packer commented 2 months ago

Backport

This PR is auto-generated from #13165 to be assessed for backporting due to the inclusion of the label backport/1.11.x.

The below text is copied from the body of the original PR.

In HCP's metadata package, especially the VCS/git parts, we keep the current HEAD for a repository, along with the state it is in, in order to report it to HCP Packer when the build completes.

However, when a build is run on a template from an empty Git repository, and HCP Packer is enabled, the code would crash when trying to get the information on the current HEAD, as it doesn't exist.

The git library we use returns an error in such a case, but this was ignored, leading to a crash when attempting to get the hash to this reference later on.

This commit fixes the problem by NOT ignoring the error to get the head, and immediately stop processing the git data as it doesn't yet exist.

Overview of commits - 7914464219346231d2c15c0128b0f051a053d9ab
github-actions[bot] commented 1 month ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.