hashicorp / packer

Packer is a tool for creating identical machine images for multiple platforms from a single source configuration.
http://www.packer.io
Other
15.12k stars 3.33k forks source link

Add S3 community provisioner to docs #13173

Closed freggy closed 1 month ago

freggy commented 1 month ago

Hey everyone, I created a provisioner supporting file retrival from S3 a while ago, and I thought it would be a good idea to add it to the docs :)

hashicorp-cla-app[bot] commented 1 month ago

CLA assistant check
All committers have signed the CLA.

hashicorp-cla-app[bot] commented 1 month ago

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

lbajolet-hashicorp commented 1 month ago

Hi @freggy,

Thanks for the PR! Before we can consider merging it, I need to ask you to sign our CLA, otherwise I won't be able to accept the PR for legal reasons, sorry about that.

On another note, we have a process for adding external plugins to our documentation website, you can find instructions on our docs, if you're interested please feel free to take a look at this and let us know if you have questions on that workflow, we'll be happy to help.

In the meantime, if you're able/willing to sign the CLA, I'll gladly review and merge your PR, thanks!

freggy commented 1 month ago

hey @lbajolet-hashicorp, I have already signed the CLA. Just tried it again and all the text fields in the form are prefilled with my information and I cannot re-sign it. For me the GitHub checklist also shows license/cla with a green checkmark.

I would be generally interested in adding the required steps to register my plugin as a Packer integration, but I can't tell when I will find time to do it. Is this required in order to have my plugin listed as a community provisioner?

lbajolet-hashicorp commented 1 month ago

Oh yeah my bad I missed the green check, the bot sometimes (often I must say, kinda problematic if you ask me) comments twice, and I miss one of the two :/ Sorry about the confusion.

Regarding integrations, it's not required no, it does offer the benefit that the plugin's docs will be accessible through https://developer.hashicorp.com/packer/integrations once the onboarding is finished, but that's up to you if/when you want to do this, no rush :)

I'll merge this today in the meantime, you should be able to see that live in the next few hours!

Thanks again for the update

freggy commented 1 month ago

no worries :) thanks for the quick response!

github-actions[bot] commented 1 week ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.