QEMU driver should accept image size as a string

hashicorp / packer

Packer is a tool for creating identical machine images for multiple platforms from a single source configuration.

http://www.packer.io

Other

15k stars 3.32k forks source link

QEMU driver should accept image size as a string #6092

Closed thedrow closed 4 years ago

thedrow commented 6 years ago

The size argument of qemu-img convert accepts the following values:

'k' or 'K' (kilobyte, 1024), 'M' (megabyte, 1024k), 'G' (gigabyte, 1024M), 'T' (terabyte, 1024G), 'P' (petabyte, 1024T) and 'E' (exabyte, 1024P) are supported. 'b' is ignored.

We should support the same convention instead of forcing the user to specify the size in MB. This will help workaround #6081 more easily.

SwampDragons commented 6 years ago

This seems like a good enhancement. The QEMU builder is a community-supported one, so we won't likely dedicate HashiCorp resources to implementing this, but I'll gladly review any PR you submit.

anshulaa commented 6 years ago

@SwampDragons I can pick it up 👍

SwampDragons commented 4 years ago

This was closed in #8320

ghost commented 4 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.