search

hashicorp / pandora

A suite of single-purpose tools enabling automation for Terraform/Azure
Mozilla Public License 2.0
65 stars 46 forks source link

Update resource-manager.hcl for nginx new version #4382

Closed zaowang-ms closed 1 week ago

zaowang-ms commented 2 weeks ago

This is the PR updating available versions of nginx on Azure.

hashicorp-cla-app[bot] commented 2 weeks ago

CLA assistant check
All committers have signed the CLA.

puneetsarna commented 2 weeks ago

Thanks for doing this @zaowang-ms . This looks good to me. Here's the link to the swagger spec 2024-06-01-preview:

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/nginx/resource-manager/NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json

puneetsarna commented 1 week ago

@catriona-m Thank you for starting to review this PR. This changeset looks very similar to https://github.com/hashicorp/pandora/pull/3830/files from @tombuildsstuff . I can't think of why the unit test would fail to import the swagger spec. Can you please share some pointers on how to start debugging this?

puneetsarna commented 1 week ago

@zaowang-ms I think I see the problem. Can you please update your feature branch on your own fork to latest main of this repository? It appears to be the case that your fork has out of date sub modules and you should sync it with the upstream (this repository) to get the unit tests to pass.

puneetsarna commented 1 week ago

@catriona-m This is an interesting issue around the fork being out of sync from the upstream (this repository). Do you think the hashicorp team can do something here to do a fail fast check during PRs to make sure that the author knows quickly what might be wrong with spec imports? If this already exists, can you please share that with me here? Thanks!!

puneetsarna commented 1 week ago

@catriona-m I see @zaowang-ms updated the fork and it now has the latest swagger submoduled. Can you please trigger the workflows again. I think they will pass now.