search

hashicorp / raft-wal

experimental raft storage
Mozilla Public License 2.0
86 stars 8 forks source link

Initial attempt to integrate with Vault with integrated storage #23

Closed hghaf099 closed 1 year ago

hghaf099 commented 1 year ago

This PR fixes a panic in finding a frame offset where the offset list does not contain the entry index.

In our hackweek project, we attempted to integrate raft-wal with Vault with integrated storage. As part of the integration, we found that snapshot restore is broken as raft with boltDB as its stable store allows for gaps in the logStore. However, raft-wal is a monotonically increasing gapless store. So, the integration test triggered the above panic.

raskchanky commented 1 year ago

Given that https://github.com/hashicorp/raft-wal/pull/24 merged, can this PR be closed?

raskchanky commented 1 year ago

I think the answer to my question is yes, so I'm going to close it, but please reopen if I'm mistaken.