Closed nandereck closed 1 year ago
Latest commit: 8c921574a9434062eb8e22493aa782c4730af309
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
react-components | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 27, 2023 6:50pm |
Latest commit: 8c921574a9434062eb8e22493aa782c4730af309
@dstaley - mind taking a look at this PR? I think I have all my bases covered but would love for someone to poke holes in this. We paired on this awhile back but I put it down when higher priority work came up.
Beyond a general review, two specific things come to mind that I'd love feedback on:
framer-motion
to the latest for these components because of its usage in other repos maybe? I can't fully remember, so if anything comes to mind, please share!One other instance I know we're using framer-motion
is in the notifications for the localized site redirects. You should be able to trigger them by setting your browser's language to Spanish/French/Japanese (such that console.log(navigator.languages)
returns an array where the first element contains es/fr/ja
). I think that one relied on layout animations, so it'd be a good test case to ensure this change works as expected.
Reference
web
PRDescription
We are currently using an old version of
framer-motion
. The most recent version offers new, useful functionality. This PR does several things:framer-motion
to the latest forreact-components
framer-motion
to the latest forreact-notification
andreact-motion-config
MotionConfig
featuresMotionConfig features
MotionConfig
is used across our properties and it allows us to reduce our bundle size by lazy loading specificframer-motion
features. Previously, we hand-picked features to load but it looks like this is no longer supported. This PR updatesMotionConfig
to usedomMax
instead of hand-picked features. When this change was tested before, I believe the difference in bundle size was pretty small (which was the reason why we hand-picked features initially).Validation Steps
In order to test this change, I've created a PR in
web
that bumpsframer-motion
and uses the canary releases for these components.Home
www
that uses the canary releases for this PRCOM
Terraform Overview