fix: correctly determine if array is empty

dstaley commented 1 year ago

🎟️ [Asana Task]() 🔍 Preview Link

Description

This PR fixes an empty array comparison. In JavaScript, arrays are objects, and equality comparisons only return true if both sides of the operator refer to the same object. By comparing to an empty array literal, this comparison will always return false. In recent versions of TypeScript, this is considered an error, which prevents builds using this code. This PR changes to compare by length instead.

PR Checklist 🚀

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

[ ] Add Asana and Preview links above.
[ ] Conduct thorough self-review.
[ ] Add or update tests as appropriate.
[ ] Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
[ ] Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
[ ] Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.