fix: add z-index to alert banner - Githubissues

hashicorp / react-components

A set of HashiCorp branded react components currently maintained and used by the marketing dev team

https://react-components.vercel.app

Mozilla Public License 2.0

60 stars 17 forks source link

fix: add z-index to alert banner #1023

Closed LeahMarieBush closed 6 months ago

LeahMarieBush commented 6 months ago

🎟️ Asana Task 🔍 Preview Link

Description

This PR adds a z index to the alert banner component. This is to prevent an overlay blur on the alert banner from the subnav dropdowns.

PR Checklist 🚀

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

[x] Add Asana and Preview links above.
[x] Conduct thorough self-review.
[x] Add or update tests as appropriate.
[x] Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
[x] Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
[x] Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-components	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 15, 2024 6:28pm

changeset-bot[bot] commented 6 months ago

🦋 Changeset detected

Latest commit: b18321fbe0bdc135e72db4387af96b084d190d92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ----------------------------- | ----- | | @hashicorp/react-alert-banner | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR