feat: use a native select element instead of @reach/listbox - Githubissues

hashicorp / react-components

A set of HashiCorp branded react components currently maintained and used by the marketing dev team

https://react-components.vercel.app

Mozilla Public License 2.0

60 stars 17 forks source link

feat: use a native select element instead of @reach/listbox #942

Closed dstaley closed 1 year ago

dstaley commented 1 year ago

🎟️ [Asana Task]() 🔍 Preview Link

Description

In our on-going effort to replace our usage of the now-deprecated Reach UI components, this PR replaces our usage of @reach/listbox in react-code-block with a native <select> element that affords virtually the same exact experience.

PR Checklist 🚀

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

[ ] Add Asana and Preview links above.
[ ] Conduct thorough self-review.
[ ] Add or update tests as appropriate.
[ ] Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
[ ] Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
[ ] Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 3ec5b351fcef5818297a077275821b051e21589f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | --------------------------- | ----- | | @hashicorp/react-code-block | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-components	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 26, 2023 10:28pm

github-actions[bot] commented 1 year ago

:package: Canary Packages Published

Latest commit: 3ec5b351fcef5818297a077275821b051e21589f

Published 1 packages

#### @hashicorp/react-code-block@6.3.0-canary-20230426224812 ``` npm install @hashicorp/react-code-block@canary ```